Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup.py #40

Merged
merged 18 commits into from
Feb 2, 2024
Merged

Add setup.py #40

merged 18 commits into from
Feb 2, 2024

Conversation

edoardob90
Copy link
Member

@edoardob90 edoardob90 commented Jan 10, 2024

Fixes #10

@Liam-Deacon
Copy link

Hi @edoardob90 - looking at the wheel build failures in Github Actions, I think the issue may be related to how CLEED is compiled via the custom Extension class used with setuptools.setup within setup.py and integrated via PEP517 pyproject.toml build hook. Looking into compiling native code recently myself I found a solution that may work well with your existing CMake files via scikit-build which should do most of the native extension heavy lifting for you 🤞

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6dccb53) 100.00% compared to head (8471004) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         8    +2     
  Lines          134       136    +2     
=========================================
+ Hits           134       136    +2     
Flag Coverage Δ
python-3.10 100.00% <ø> (?)
python-3.11 100.00% <ø> (ø)
python-3.12 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edoardob90
Copy link
Member Author

Thank you @Liam-Deacon for the comment.

I indeed had a look into scikit-build but couldn't figure out properly how to adapt the examples based on C++ to our interface with a pure C code. The current setup is a bit "dirty" but it works.

Other hints on to use that build system are obviously welcomed.

@Liam-Deacon
Copy link

Thank you @Liam-Deacon for the comment.

I indeed had a look into scikit-build but couldn't figure out properly how to adapt the examples based on C++ to our interface with a pure C code. The current setup is a bit "dirty" but it works.

Other hints on to use that build system are obviously welcomed.

Glad to see you got it building - nice work!

@edoardob90 edoardob90 requested a review from baffelli January 15, 2024 15:37
@edoardob90 edoardob90 merged commit 2a7badf into main Feb 2, 2024
9 checks passed
@edoardob90 edoardob90 deleted the add-setup-py branch February 2, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setup.py to compile the code during the installation process
3 participants